Three Fixes: Unity.ugui Issue; NUnit meta parsing; 2019/2018 warning #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2020 14:28
andreiborodin
added
bug
chrisfromwork
approved these changes
Jan 10, 2020
mhochk
reviewed
Jan 10, 2020
| } | ||
|
|
||
| // Now we have all of the assembly definiton files, let's run a quick validation on the references to correct known errors like "unity.ugui" supposed to be "UnityEngine.UI" | ||
| /// <see cref="ProjectAliases"/> for the correction map. |
Member
There was a problem hiding this comment.
NIT on the comment style. Double // on one line and triple on the other? #Resolved
Contributor
Author
There was a problem hiding this comment.
Yeah, just to put the <see cref; but on further thought I will just move it to the function
In reply to: 365450151 [](ancestors = 365450151)
mhochk
reviewed
Jan 10, 2020
| { | ||
| // No define constraints | ||
| } | ||
| else if (match.Success) // We have non-empty string in teh contents of the group we matched; NUnit has this: defineConstraints: ["UNITY_INCLUDE_TESTS"] |
Member
There was a problem hiding this comment.
teh [](start = 75, length = 3)
the #Resolved
mhochk
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three fixes:
Fixes #97.