A simple Cross-Unity Project Dependency Relationship #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 10, 2020 15:30
andreiborodin
added
enhancement
andreiborodin
requested review from
CoPrez,
chrisfromwork,
mhochk and
ryantrem
| @@ -0,0 +1,16 @@ | |||
| using CommonLibrary; | |||
| using UnityEngine; | |||
Contributor
There was a problem hiding this comment.
add license header #Resolved
| public string GetThisDataToo() | ||
| { | ||
| return "IntegartedDependencies Project + {commonComponent.GetData()}"; | ||
| } |
Contributor
There was a problem hiding this comment.
nit: this should be $"" #Resolved
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\ExternalLib\ExternalLib.csproj" /> | ||
| </ItemGroup> | ||
| --> |
Contributor
There was a problem hiding this comment.
do you think we benefit from having this much content in all generated files? It kind of seems like if I was only shown a reference example this file would be less intimidating for someone new to csproj definitions. #WontFix
Contributor
There was a problem hiding this comment.
reducing the amount of content in this file will make it easier to read in things like notepad
In reply to: 367709527 [](ancestors = 367709527)
Contributor
Author
There was a problem hiding this comment.
I will keep it for now, but will consider it in the future.
In reply to: 367709703 [](ancestors = 367709703,367709527)
ryantrem
approved these changes
Jan 17, 2020
chrisfromwork
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets up support for a Unity-to-Unity project dependency relationship and adds a sample shwocasing this support.