Reworked Platform Props Exporting #110
Conversation
… as for common props file.
| /// <param name="inEditor">Whether to export the inEditor version.</param> | ||
| public static void ExportCoreUnityPropFile(IUnityProjectExporter exporter, CompilationPlatformInfo platform, bool inEditor) | ||
| { | ||
| string configuration = inEditor ? "InEditor" : "Player"; |
There was a problem hiding this comment.
"InEditor" : "Player" [](start = 46, length = 21)
it feels like these should be hard coded as constants somewhere for consistency throughout the exporters
There was a problem hiding this comment.
Possibly, but will save that for a later change.
nit: remove "All rights reserved." Refers to: Source/MSBuildTools.Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectGenerator/Scripts/Exporters/IPlatformPropsExporter.cs:1 in 3252586. [](commit_id = 3252586, deletion_comment = False) |
| /// </summary> | ||
| /// <param name="path">The <see cref="FileInfo"/> representing where this props file will be written.</param> | ||
| /// <param name="scriptingBackend">The scripting backend for the platform props.</param> | ||
| IWSAPlayerPlatformPropsExporter CreateWSAPlayerPlatformPropsExporter(FileInfo path, ScriptingBackend scriptingBackend); |
There was a problem hiding this comment.
CreateWSAPlayerPlatformPropsExporter [](start = 40, length = 36)
are we going to need a custom exporter for each platform/player combination? Are there specific things needed on IWSAPlayerPlatformPropsExporter that wouldn't pertain to other platforms?
There was a problem hiding this comment.
Yes, and yes Min/Max target UWP platform.
|
Putting it in, will remove the copyright in a subsequent PR I will be putting out soon. |
This follows the same approach as #109 in updating how the exporter logic is split up for a cleaner and well understood split of responsibilities.