Top-Level Project Generation Change #111
Conversation
| public static void RegenerateSDKProjects() | ||
| { | ||
| RegenerateEverything(reparseUnityData: true); | ||
| RegenerateEverything(unityProjectInfo = new UnityProjectInfo(SupportedBuildTargets, Config, true)); |
There was a problem hiding this comment.
true [](start = 104, length = 4)
nit: specify the argument name here for the true. #Pending
| } | ||
|
|
||
| public static void ExportTopLevelDependenciesProject(IUnityProjectExporter exporter, MSBuildToolsConfig config, DirectoryInfo generatedProjectFolder, UnityProjectInfo unityProjectInfo) | ||
| { |
There was a problem hiding this comment.
nit: add summary #WontFix
There was a problem hiding this comment.
Leaving for now, as this class is temporary so I can split off the logic and then adapt it in the appropriate place.
In reply to: 369676752 [](ancestors = 369676752)
| } | ||
|
|
||
| public void Dispose() | ||
| { |
There was a problem hiding this comment.
nit: add summary #Pending
| // Logging will be re-enabled with robust update holistically across MSB4U: https://github.com/microsoft/MSBuildForUnity/issues/75 | ||
| // Debug.Log($"Native plugin {plugin.ReferencePath.AbsolutePath} not yet supported for MSBuild project."); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: remove this foreach if its a noop. Or comment it all out #Pending
| public string Condition { get; set; } | ||
|
|
||
| public override int GetHashCode() | ||
| { |
There was a problem hiding this comment.
nit: add inheritdoc for these overrides
|
How were these changes tested? |
…ndenciesProjectGeneration
…o propogate to top level project
|
Tested this with all three samples, and actually the work you been doing in SpectatorView.Unity In reply to: 577283613 [](ancestors = 577283613) |
keveleigh
left a comment
keveleigh
left a comment
There was a problem hiding this comment.
Nothing jumps out at me
andreiborodin
deleted the
features/updateDependenciesProjectGeneration
branch
This change updates how we perform top-level project generation, and a bit of other cleanup.