Dependency Project Explicit Target Framework #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k after importing the commons file. This fixes an issue with VS2019
wiwei
approved these changes
Jan 30, 2020
keveleigh
approved these changes
Jan 30, 2020
andreiborodin
deleted the
bugs/updateTFMSpecificationInDependenciesProject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In projects that are built for AsmDef, we don't know the target framework until we import the platform props, and that depends on the UnityConfig/UnityPlatform pairing we are building with.
For the top-level dependencies project we do, it's specifies in the common props file, so just set it immediately. This fixes an issue with VS2019.