-
Notifications
You must be signed in to change notification settings - Fork 32
OSX Support #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX Support #91
Conversation
....Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectBuilder/MSBuildProjectBuilder.cs
Outdated
Show resolved
Hide resolved
...buildforunity/Editor/ProjectGenerator/MSBuildTemplates/SDKProjectTemplate.g.targets.template
Outdated
Show resolved
Hide resolved
.../com.microsoft.msbuildforunity/Editor/ProjectGenerator/MSBuildTemplates/UnixNetSupport.props
Show resolved
Hide resolved
...Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectGenerator/Scripts/MSBuildTools.cs
Outdated
Show resolved
Hide resolved
This function appears to be available in Unity starting in 2017. UnityEditor.BuildPipeline.GetBuildTargetGroup(BuildTarget buildTarget) Refers to: Source/MSBuildTools.Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectGenerator/Scripts/Utilities.cs:576 in 58783b0. [](commit_id = 58783b0, deletion_comment = False) |
.../com.microsoft.msbuildforunity/Editor/ProjectGenerator/MSBuildTemplates/UnixNetSupport.props
Show resolved
Hide resolved
....Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectBuilder/MSBuildProjectBuilder.cs
Outdated
Show resolved
Hide resolved
mhochk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Adding support for OSX, which should technically work on Linux as well. This fixes the #68 issue.
This change does a couple of things: