Skip to content

Conversation

@andreiborodin
Copy link
Contributor

Adding support for OSX, which should technically work on Linux as well. This fixes the #68 issue.

This change does a couple of things:

  • Fixes all path operations with appropriate slash ('/')
  • Fixes built-in package search path for macOS.
  • Adds Unix .NET Support props file that retargets to Mono
  • Fixes up the executable path for dotnet and msbuild.
  • Updates Sample's external C# project to work with .NET 4.6 Reference Assemblies.

@andreiborodin andreiborodin added enhancement New feature or request OSX Issues encountered on the OSX platform. Linux Issues encountered on the Linux platform. labels Dec 19, 2019
@andreiborodin andreiborodin added this to the 0.9.0 Release milestone Dec 19, 2019
@mhochk
Copy link
Member

mhochk commented Dec 19, 2019

    public static BuildTargetGroup GetBuildTargetGroup(BuildTarget buildTarget)

This function appears to be available in Unity starting in 2017.

UnityEditor.BuildPipeline.GetBuildTargetGroup(BuildTarget buildTarget)


Refers to: Source/MSBuildTools.Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectGenerator/Scripts/Utilities.cs:576 in 58783b0. [](commit_id = 58783b0, deletion_comment = False)

@mhochk
Copy link
Member

mhochk commented Dec 19, 2019

    /// Gets a normalized path (with back slashes only), and optionally can make full path.

NIT: Update comment


Refers to: Source/MSBuildTools.Unity/Packages/com.microsoft.msbuildforunity/Editor/ProjectGenerator/Scripts/Utilities.cs:372 in 58783b0. [](commit_id = 58783b0, deletion_comment = False)

Copy link
Member

@mhochk mhochk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andreiborodin andreiborodin merged commit d23d3cc into master Dec 23, 2019
@andreiborodin andreiborodin deleted the features/macSupport branch December 23, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Linux Issues encountered on the Linux platform. OSX Issues encountered on the OSX platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants