Bugfix: https://github.com/microsoft/MSBuildLocator/issues/176#177
Closed
bernd5 wants to merge 2 commits into
Closed
Bugfix: https://github.com/microsoft/MSBuildLocator/issues/176#177bernd5 wants to merge 2 commits into
bernd5 wants to merge 2 commits into
Conversation
dotNetSdkPath may not end with / or \ - we can't concat
|
|
Author
|
Anything to change here? |
Author
|
Please review this PR |
Contributor
|
Sorry I was a bit slow. This change and #178 seem roughly equivalent, and they're both correct as far as I can tell. That one is a more targeted change, but this one avoids allocating a dictionary unnecessarily. I just happened to see that first, so I merged it. This change looks good, too! Since I already merged that one, I'll close this, but thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #176
dotNetSdkPath may not end with / or \ - we can't use simple concat