Skip to content

Fix nullref in GetCopyToPublishDirectoryItemsGraphPredictor#123

Merged
dfederm merged 1 commit intomainfrom
fix-sfproj-publish
Oct 28, 2024
Merged

Fix nullref in GetCopyToPublishDirectoryItemsGraphPredictor#123
dfederm merged 1 commit intomainfrom
fix-sfproj-publish

Conversation

@dfederm
Copy link
Copy Markdown
Member

@dfederm dfederm commented Oct 28, 2024

This is happening for sfproj projects because in ServiceFabricCopyFilesToPublishDirectoryGraphPredictor, it passes a null publishDir to GetCopyToPublishDirectoryItemsGraphPredictor:

// A service fabric project publishes its dependencies with its own publish dir. However, we're not providing the publish dir
// since that requires cracking open the service manifest to find the correct subdir. Instead we'll just predict the directory.
foreach (ProjectGraphNode projectReference in projectGraphNode.ProjectReferences)
{
    GetCopyToPublishDirectoryItemsGraphPredictor.PredictInputsAndOutputs(projectReference, publishDir: null, predictionReporter);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant