Traversal: Have GetTargetPath return collected build outputs#338
Traversal: Have GetTargetPath return collected build outputs#338jeffkl merged 3 commits intomicrosoft:mainfrom
Conversation
microsoft@1c02e77 I made the GetTargetPath target for traversal projects return nothing. This is actually wrong as msbuild projects are expected to return the same data in the Build and the GetTargetPath target. If those two targets aren't in sync, a behavior difference is observable when a traversal project is P2Pd and the dependent project reads from the `CollectedBuildOutput` (which is returned by the `ResolveProjectReferences` target). If the `BuildProjectReferences=true` flag is passed in, the output in the ResolveP2P is currently empty vs. not empty during a normal build without the flag set.
|
@ViktorHofer this is super cool! Any chance you have time to write some unit tests? If not, I should have some time today to do it and push to your branch. |
|
To be honest I still haven't familiarized myself with testing msbuild components in neither this repo nor msbuild nor the sdk. At some I definitely want to close that gap but at the moment I would prefer to not spend time on that as I have little time at the moment. If you don't mind Jeff, it would be great if you could add them. |
No worries, this is definitely the kind of area where the unit testing is a bit of a unicorn since we're exercising MSBuild logic. That's why I offered, I'll push a commit later today. |
jeffkl
changed the title
jeffkl
force-pushed
the
patch-5
branch
7 times, most recently
from
b848a40 to
e2ea79c
Compare
|
Awesome. Can you please push a new version to nuget? That would be fantastic. |
|
I am actively working on releasing new bits, the official build is failing with some signing issues so I'm retrying... |
|
In case it helps, arcade repos like dotnet/runtime use the version 3 of the |
| Traversal projects do not build an assembly so dependent projects shouldn't get a path to the target. Override the GetTargetPath to do nothing. | ||
| --> | ||
| <Target Name="GetTargetPath" /> | ||
| <Target Name="GetTargetPath" |
There was a problem hiding this comment.
@ViktorHofer I think GetTargetPath isn't available for a multi targeting build. So if one of the project references is multing-targeting (e.g, <TargetFrameworks>net9.0;net10</TargetFrameworks>), this would fail because the project doesn't have the target defined. What should be the right behavior here?
3 participants
1c02e77 I made the GetTargetPath target for traversal projects return nothing. This is actually wrong as msbuild projects are expected to return the same data in the Build and the GetTargetPath target.
If those two targets aren't in sync, a behavior difference is observable when a traversal project is P2Pd and the dependent project reads from the
CollectedBuildOutput(which is returned by theResolveProjectReferencestarget). If theBuildProjectReferences=trueflag is passed in, the output in the ResolveP2P is currently empty vs. not empty during a normal build without the flag set.I tested this locally and am also submitting a PR into dotnet/runtime right now which depends on this behavior (currently via the AfterTargets extension point of the Traversal project). Would be great if we could get this into main here so that I can remove the custom implementation in dotnet/runtime.
cc @jeffkl