Added tests for the oculus integration tool #8519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogPodge
requested review from
CDiaz-MS,
MaxWang-MS,
david-c-kline,
keveleigh and
wiwei
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
Sep 10, 2020
...MRTK/Providers/Oculus/XRSDK/MRTK-Quest/Editor/OculusXRSDKHandtrackingConfigurationChecker.cs
Show resolved
Hide resolved
wiwei
reviewed
Sep 10, 2020
Assets/MRTK/Tests/EditModeTests/Editor/OculusIntegrationSetupTests.cs
Outdated
Show resolved
Hide resolved
wiwei
reviewed
Sep 10, 2020
Assets/MRTK/Tests/EditModeTests/Editor/OculusIntegrationSetupTests.cs
Outdated
Show resolved
Hide resolved
wiwei
approved these changes
Sep 10, 2020
Contributor
wiwei
left a comment
wiwei
left a comment
There was a problem hiding this comment.
Change lgtm modulo @keveleigh's comment
MaxWang-MS
reviewed
Sep 10, 2020
Assets/MRTK/Tests/EditModeTests/Editor/OculusIntegrationSetupTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added tests and cleaned up files associated with #8259 and #8386