You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure if this is the root cause, cause I'm able to run test_transcription.py with ORT 1.17.1 successfully without --predict_timestamps. Do you know the reason?
I'm not sure if this is the root cause, cause I'm able to run test_transcription.py with ORT 1.17.1 successfully without --predict_timestamps. Do you know the reason?
@xiaoyu-work you can see in this PR microsoft/onnxruntime#19509 that some token ids are now part of the model attributes and not inferred using offsets. This affects the logits processor which does the time stamp prediction. I think the lack of these values in the beam search node's attributes causes the issue.
I'm not sure if this is the root cause, cause I'm able to run test_transcription.py with ORT 1.17.1 successfully without --predict_timestamps. Do you know the reason?
@xiaoyu-work you can see in this PR microsoft/onnxruntime#19509 that some token ids are now part of the model attributes and not inferred using offsets. This affects the logits processor which does the time stamp prediction. I think the lack of these values in the beam search node's attributes causes the issue.
I'm not sure if this is the root cause, cause I'm able to run test_transcription.py with ORT 1.17.1 successfully without --predict_timestamps. Do you know the reason?
@xiaoyu-work you can see in this PR microsoft/onnxruntime#19509 that some token ids are now part of the model attributes and not inferred using offsets. This affects the logits processor which does the time stamp prediction. I think the lack of these values in the beam search node's attributes causes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
ORT 1.17.1 made some changes to the beam search ops. For version 1.17.1, the beam search op used will be
WhisperBeamSearch.Fixes:
#1014
Checklist before requesting a review
lintrunner -a(Optional) Issue link