Add file header to editorconfig#241
Merged
Merged
Conversation
Add file header to editorconfig
muiriswoulfe
approved these changes
Aug 21, 2020
|
|
||
| # Typescript and javascript files | ||
| [*.{ts,js}] | ||
| #indent_size = 4 |
Member
There was a problem hiding this comment.
I realise this isn't part of this change, but do we really want this given that is commented out?
| [*.vb] | ||
| # Modifier preferences | ||
| visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion No newline at end of file | ||
| visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion |
Member
There was a problem hiding this comment.
Do we definitely want to include this? We don't have any Visual Basic files and I doubt we ever will
Contributor
Author
|
@muiriswoulfe thank you for your comments, I'll address them in another PR (created in issue #266) and sorry for the delay, I'll merge it as it is to avoid people missing headers |
vlad-ion
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file header to editorconfig