XS⚠️ ◾ Release v1.7.4: Adding Code Signing#619
Merged
Conversation
Contributor
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
- Updated friendly name and version in resources.resjson and task.json - Incremented version in package.json and package-lock.json - Changed user agent in gitHubReposInvoker.ts and corresponding test - Updated version in vss-extension.json and task localization files
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release pipeline to add static IP usage, include code signing via ESRP, and bumps the PR Metrics version from 1.7.3 to 1.7.4 across manifests, code, and docs.
- Release pipeline changes: switch to static IP pool, add PR Metrics variable group, and insert EsrpCodeSigning@5 task.
- Version bumps: updated version strings in JSON configs, code outputs, tests, package.json, and README.
- Formatting: minor JSON reformatting in vss-extension.json.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vss-extension.json | Bumped extension version to 1.7.4 |
| src/task/tests/repos/gitHubReposInvoker.spec.ts | Updated expectedUserAgent to “PRMetrics/v1.7.4” |
| src/task/task.loc.json | Updated patch version to 4 |
| src/task/task.json | Bumped friendlyName and patch version to 1.7.4 |
| src/task/src/repos/gitHubReposInvoker.ts | Updated userAgent string to “PRMetrics/v1.7.4” |
| src/task/Strings/resources.resjson/en-US/resources.resjson | Updated loc.friendlyName to “PR Metrics v1.7.4” |
| package.json | Bumped package version to 1.7.4 |
| README.md | Updated GitHub Actions usage tag to v1.7.4 |
| .github/workflows/support/release-trigger.txt | Updated release trigger version to 1.7.4 |
| .github/workflows/release-phase-1.yml | Updated patch number (see comment below) |
| .github/azure-devops/release.yml | Switched pool to static IP, added PR Metrics variable group, and inserted ESRP code signing task |
Comments suppressed due to low confidence (1)
.github/workflows/release-phase-1.yml:24
- The patch version is set to 5 here, but the PR is for v1.7.4; it should be
patch: 4to match the intended release.
patch: 5
neilr81
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes includes updates to the release pipeline, the inclusion of code signing, a version bump for the
PR Metricstool, and minor formatting improvements to configuration files. Below is a summary of the most important changes:Release Pipeline Enhancements:
Azure-Pipelines-1ESPT-ExDShared-StaticIP) and added a variable group forPR Metrics. (.github/azure-devops/release.yml, .github/azure-devops/release.ymlL61-R65)EsrpCodeSigning@5task for signing.vsixfiles with ESRP code signing credentials. (.github/azure-devops/release.yml, .github/azure-devops/release.ymlR95-R127)Version Updates:
PR Metricsfrom1.7.3to1.7.4across multiple files, includingpackage.json,README.md,task.json, andvss-extension.json. [1] [2] [3] [4]Configuration and Metadata Improvements:
vss-extension.jsonfor better readability. (src/vss-extension.json, [1] [2]userAgentstring ingitHubReposInvoker.tsand its associated test to reflect the new version. (src/task/src/repos/gitHubReposInvoker.ts, [1];src/task/tests/repos/gitHubReposInvoker.spec.ts, [2]Testing
Test Types