Skip to content

XS⚠️ ◾ Release v1.7.4: Adding Code Signing#619

Merged
muiriswoulfe merged 20 commits into
mainfrom
muiriswoulfe/code-signing
Jul 9, 2025
Merged

XS⚠️ ◾ Release v1.7.4: Adding Code Signing#619
muiriswoulfe merged 20 commits into
mainfrom
muiriswoulfe/code-signing

Conversation

@muiriswoulfe
Copy link
Copy Markdown
Member

@muiriswoulfe muiriswoulfe commented Jul 3, 2025

Summary

This changes includes updates to the release pipeline, the inclusion of code signing, a version bump for the PR Metrics tool, and minor formatting improvements to configuration files. Below is a summary of the most important changes:

Release Pipeline Enhancements:

  • Updated the Azure DevOps release pipeline to use a static IP pool (Azure-Pipelines-1ESPT-ExDShared-StaticIP) and added a variable group for PR Metrics. (.github/azure-devops/release.yml, .github/azure-devops/release.ymlL61-R65)
  • Introduced the EsrpCodeSigning@5 task for signing .vsix files with ESRP code signing credentials. (.github/azure-devops/release.yml, .github/azure-devops/release.ymlR95-R127)

Version Updates:

  • Incremented the version of PR Metrics from 1.7.3 to 1.7.4 across multiple files, including package.json, README.md, task.json, and vss-extension.json. [1] [2] [3] [4]

Configuration and Metadata Improvements:

  • Reformatted JSON arrays and objects in vss-extension.json for better readability. (src/vss-extension.json, [1] [2]
  • Updated the userAgent string in gitHubReposInvoker.ts and its associated test to reflect the new version. (src/task/src/repos/gitHubReposInvoker.ts, [1]; src/task/tests/repos/gitHubReposInvoker.spec.ts, [2]

Testing

Test Types

  • Unit tests
  • Manual tests

@muiriswoulfe muiriswoulfe self-assigned this Jul 3, 2025
Copilot AI review requested due to automatic review settings July 3, 2025 16:56
@muiriswoulfe muiriswoulfe requested a review from a team as a code owner July 3, 2025 16:56
@muiriswoulfe muiriswoulfe added the enhancement New feature or request label Jul 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 3, 2025

PR Metrics

Thanks for keeping your pull request small.
⚠️ Consider adding additional tests.

Lines
Product Code 2
Test Code 1
Subtotal 3
Ignored Code 49
Total 52

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title [WIP] Adding Code Signing XS✔ ◾ [WIP] Adding Code Signing Jul 3, 2025

This comment was marked as outdated.

- Updated friendly name and version in resources.resjson and task.json
- Incremented version in package.json and package-lock.json
- Changed user agent in gitHubReposInvoker.ts and corresponding test
- Updated version in vss-extension.json and task localization files
Comment thread package-lock.json
@microsoft microsoft deleted a comment from github-actions Bot Jul 9, 2025
@microsoft microsoft deleted a comment from github-actions Bot Jul 9, 2025
@omex-github-bot-external omex-github-bot-external changed the title XS✔ ◾ [WIP] Adding Code Signing XS⚠️ ◾ [WIP] Adding Code Signing Jul 9, 2025
@github-actions github-actions Bot changed the title XS⚠️ ◾ [WIP] Adding Code Signing XS✔ ◾ [WIP] Adding Code Signing Jul 9, 2025
@muiriswoulfe muiriswoulfe changed the title XS✔ ◾ [WIP] Adding Code Signing XS⚠️ ◾ Release v1.7.4: Adding Code Signing Jul 9, 2025
@microsoft microsoft deleted a comment from github-actions Bot Jul 9, 2025
@microsoft microsoft deleted a comment from github-actions Bot Jul 9, 2025
@muiriswoulfe muiriswoulfe requested a review from Copilot July 9, 2025 12:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the release pipeline to add static IP usage, include code signing via ESRP, and bumps the PR Metrics version from 1.7.3 to 1.7.4 across manifests, code, and docs.

  • Release pipeline changes: switch to static IP pool, add PR Metrics variable group, and insert EsrpCodeSigning@5 task.
  • Version bumps: updated version strings in JSON configs, code outputs, tests, package.json, and README.
  • Formatting: minor JSON reformatting in vss-extension.json.

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vss-extension.json Bumped extension version to 1.7.4
src/task/tests/repos/gitHubReposInvoker.spec.ts Updated expectedUserAgent to “PRMetrics/v1.7.4”
src/task/task.loc.json Updated patch version to 4
src/task/task.json Bumped friendlyName and patch version to 1.7.4
src/task/src/repos/gitHubReposInvoker.ts Updated userAgent string to “PRMetrics/v1.7.4”
src/task/Strings/resources.resjson/en-US/resources.resjson Updated loc.friendlyName to “PR Metrics v1.7.4”
package.json Bumped package version to 1.7.4
README.md Updated GitHub Actions usage tag to v1.7.4
.github/workflows/support/release-trigger.txt Updated release trigger version to 1.7.4
.github/workflows/release-phase-1.yml Updated patch number (see comment below)
.github/azure-devops/release.yml Switched pool to static IP, added PR Metrics variable group, and inserted ESRP code signing task
Comments suppressed due to low confidence (1)

.github/workflows/release-phase-1.yml:24

  • The patch version is set to 5 here, but the PR is for v1.7.4; it should be patch: 4 to match the intended release.
      patch: 5

@muiriswoulfe muiriswoulfe requested a review from neilr81 July 9, 2025 14:22
@muiriswoulfe muiriswoulfe merged commit e7b545b into main Jul 9, 2025
28 checks passed
@muiriswoulfe muiriswoulfe deleted the muiriswoulfe/code-signing branch July 9, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants