XGPM Main page + Preview - MSIXVC2 Support#108
Merged
WilliamsJason merged 10 commits intomicrosoft:mainfrom Mar 25, 2026
Merged
XGPM Main page + Preview - MSIXVC2 Support#108WilliamsJason merged 10 commits intomicrosoft:mainfrom
WilliamsJason merged 10 commits intomicrosoft:mainfrom
Conversation
… folder, and preview completed
elahmed-microsoft
changed the title
WilliamsJason
requested changes
Mar 20, 2026
Collaborator
WilliamsJason
left a comment
WilliamsJason
left a comment
There was a problem hiding this comment.
I think the only thing blocking a V1 of this for me is the legacy upload path problem I commented on. Some other nice to haves though you might want to think about:
- If we could find a way to share the auth that PackageUploader already requests with MakePkg2. Maybe passing '/auth default' will work? It would be nice to save the extra browser pop.
- We should consider disabling the option when MakePkg2 isn't available with a message that it's an April GDK preview feature and people wanting to test it out should check out the April 2026 GDK. Rather than the current behavior of letting people try and then failing if it's not there.
- Might be worth checking with the authors of MakePkg2 around progress reporting, if the shared method allows reporting on a 'stage' or 'step' in addition to a 'percentage' then we could let MakePkg2 have the responsibility for deciding what step we are on and what % complete we are, and simplify the regex logic.
WilliamsJason
approved these changes
Mar 25, 2026
Collaborator
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces updates made to the landing page of XGPM as well as the MSIXVC2 specific page in the initial steps of adding support to MSIXVC2
Note: this is strictly a UI change.