Skip to content
This repository was archived by the owner on Dec 22, 2020. It is now read-only.

Conversation

@diego-d5000
Copy link

@diego-d5000 diego-d5000 commented Jun 27, 2017

Description

Questison

please answer the following questions. put x inside [ ] (e.g. [x])

What inside?

  • Bug Fixes?
  • New Features? (generated code)
  • Documentation? (readme basic example)

Is pull request totally generated from swagger file?

  • Yes.
  • No, part of it is auto-generated. (I include other changes necessaries to work with the new generated code)

Backward compatibility break?

  • Yes. Pull request breaks backward compatibility! (I left the old code intact and put generated code in another folder and another main class, so "backward compatibility" doesn't break)

Learn more about backward compatibility.

@diego-d5000 diego-d5000 changed the title Updated SDK to V2 Update SDK to V2 Jun 27, 2017
@diego-d5000 diego-d5000 changed the base branch from master to dev June 28, 2017 18:12
@diego-d5000
Copy link
Author

diego-d5000 commented Jun 28, 2017

Sorry. I started from master at the beginning, so I made a rebase to "dev" branch to change the parent branch.

@diego-d5000
Copy link
Author

@ali-hamud could you check it please ?

@ali-hamud
Copy link
Contributor

Hi Diego,
Thank you for the pull request.
As we got more requests to update this, we will give it higher priority. I"ll look into it next week.

@ali-hamud
Copy link
Contributor

Hi,
Code looks OK except of the Import code.
Import code is still using azure Workspace collections and didn't moved to the new pattern.
Do you want me to take it from here?

@ali-hamud
Copy link
Contributor

Another thing:
calling super from constructor throws this error:
Class constructor PowerBIClient cannot be invoked without 'new'

I think This is related to changes of versions in package.json and typings file.

@diego-d5000
Copy link
Author

Thanks for the review @ali-hamud I'll check it to commit the fixes

@diego-d5000
Copy link
Author

@ali-hamud I would apreciated if you could help me with the Imports code and some test for replicate the error. Thanks

@ali-hamud
Copy link
Contributor

sure. I provide it tomorrow.

@ali-hamud
Copy link
Contributor

I succeeded to solve the issue. I will update later.

@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@djasnowski
Copy link

Any updates on this? @ali-hamud

@ali-hamud
Copy link
Contributor

Please note that we have deprecate this library.

@djasnowski
Copy link

That's unfortunate @ali-hamud.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants