Merged
Conversation
Closed
Contributor
|
Looks good, obviously this is a quick fix but I'd say let's 💃 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AdriaanRol @MerlinSmiles A simple fix for the timeout issues. I'm going to leave #136 open until I clean up some more - as I mention in a TODO in this PR, I think I can simplify more by getting rid of the
error_queuecompletely and just coding responses and errors differently in theresponse_queue, but when I do that I also want to unify the way all servers receive and respond to queries so theask/writedistinction is really robust.