fix: Keithley_2400 READ? format may be inconsistent#1876
Merged
jenshnielsen merged 5 commits intomicrosoft:masterfrom Jan 2, 2020
Merged
Conversation
Added code to ensure Keithley 2400 instrument sends responses to READ? in correct format in the driver __init__ method. Modify 'output' parameter to use create_on_off_val_mapping instead of int. Breaking changes: 'output' parameter type change could possibly break existing code that depends on 'output' being an int.
Codecov Report
@@ Coverage Diff @@
## master #1876 +/- ##
==========================================
- Coverage 70.37% 70.37% -0.01%
==========================================
Files 152 152
Lines 18875 18877 +2
==========================================
+ Hits 13283 13284 +1
- Misses 5592 5593 +1 |
astafan8
approved these changes
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 'bugginess' mentioned in #488
Changes proposed in this pull request:
Breaking changes: 'output' parameter type change could possibly break existing code that depends on 'output' being an int.
@WilliamHPNielsen