Skip to content

feat: Add driver for Keysight N9030B#2553

Merged
Akshita07 merged 87 commits intomicrosoft:masterfrom
neildick:feat/keysight_N9030B
Jan 26, 2021
Merged

feat: Add driver for Keysight N9030B#2553
Akshita07 merged 87 commits intomicrosoft:masterfrom
neildick:feat/keysight_N9030B

Conversation

@neildick
Copy link
Contributor

@neildick neildick commented Dec 21, 2020

Add barebones skeleton for the Keysight N9030B. Functionality to
follow.

Fixes #781.

Changes proposed in this pull request:

  • Driver for Keysight N9030B
  • SA mode basic functionality
  • Phase Noise mode basic functionality
  • Add yaml file for instrument simulation
  • Add example notebook
  • Write tests
  • Test driver on instrument

@WilliamHPNielsen ping

Add barebones skeleton for the Keysight N9030B. Functionality to
follow.
@neildick neildick marked this pull request as draft December 21, 2020 23:05
Neil Dick added 2 commits December 22, 2020 10:35
Add the missing type annotations for the main class.
Add a few instrument parameters that depend on the ArrayParameter
subclass.
@neildick neildick changed the title feat: Add skeleton for Keysight N9030B feat: Add driver for Keysight N9030B Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #2553 (dd1e616) into master (ef8b065) will increase coverage by 0.07%.
The diff coverage is 74.24%.

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
+ Coverage   63.71%   63.79%   +0.07%     
==========================================
  Files         198      199       +1     
  Lines       26020    26218     +198     
==========================================
+ Hits        16579    16726     +147     
- Misses       9441     9492      +51     

@astafan8 astafan8 added this to the 0.22.0 milestone Jan 11, 2021
@Akshita07 Akshita07 marked this pull request as ready for review January 14, 2021 14:07
@Akshita07 Akshita07 merged commit 25d4ba1 into microsoft:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

driver/Keysight N9030b spectrum analyzer

6 participants