Skip to content

Fix QtPlot#446

Merged
jenshnielsen merged 4 commits intomicrosoft:masterfrom
VandersypenQutech:fix/qtplot
Jan 13, 2017
Merged

Fix QtPlot#446
jenshnielsen merged 4 commits intomicrosoft:masterfrom
VandersypenQutech:fix/qtplot

Conversation

@peendebak
Copy link
Contributor

@peendebak peendebak commented Jan 12, 2017

This PR takes elements from #387.

Changes proposed in this pull request:

  • Rename windowTitle argument to window_title
  • Add setGeometry function

@core @Unga @MerlinSmiles

eendebakpt and others added 4 commits January 12, 2017 14:54
@eendebakpt
fix argument name
814ea0d
@eendebakpt
add setGeometry function
a9c705e
@eendebakpt
autopep
7102d4e
@jenshnielsen
Fix: handle old windowTitle argument
904cb40 
This avoids a wierd warning in case users have not updated their code.
@jenshnielsen jenshnielsen merged commit 139ddc4 into microsoft:master Jan 13, 2017
@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Jan 13, 2017

Added a check for the old argument name otherwise +1

giulioungaretti pushed a commit that referenced this pull request Jan 13, 2017
Generated gh-pages for commit 139ddc4
7919b8c 
Merge: 597c157 904cb40
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>

    Merge pull request #446 from VandersypenQutech/fix/qtplot
@peendebak peendebak deleted the fix/qtplot branch February 3, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peendebak @jenshnielsen @eendebakpt