Conversation
|
There is also a PR #488 by @WilliamHPNielsen |
|
@jenshnielsen good point, didnt spot that. Thanks. It looks much more comprehensive than this one so I'll close this one. Would be fab if the other one could be merged soon though as it seems like it's a pretty useful driver (given that 3 people have now written it). Also are we no longer giving prs a 'driver' tag? I should have checked more carefully anyway but the reason I didnt see #488 is because I looked for 'driver' prs rather than 'feat's |
|
@nataliejpg yes that's the idea to have drive/foo but being humans we tend to fail sometimes :D |
|
also @nataliejpg it is under driver/foo 🌹 |
|
@giulioungaretti cool cool, just wanted to check, it wasn't a moan (although I did double check and it's under 'feat: Add basic driver for Keithley 2400' so I wouldn't have called that 'driver/foo'. It did make me realise that the ZNB20 update I did is under feat as well where it shouldn't be so @WilliamHPNielsen is by no means the only fallible one) |
|
<3 <3 |
Changes proposed in this pull request:
@giulioungaretti