Skip to content

Driver/keithley2400#515

Closed
nataliejpg wants to merge 5 commits intomicrosoft:masterfrom
nataliejpg:driver/Keithley2400
Closed

Driver/keithley2400#515
nataliejpg wants to merge 5 commits intomicrosoft:masterfrom
nataliejpg:driver/Keithley2400

Conversation

@nataliejpg
Copy link
Contributor

Changes proposed in this pull request:

  • add a basic keithley 2400 driver
  • could be extended/merged with this old one here
  • needs (better) docstrings (?)

@giulioungaretti

@jenshnielsen
Copy link
Collaborator

There is also a PR #488 by @WilliamHPNielsen

@nataliejpg
Copy link
Contributor Author

@jenshnielsen good point, didnt spot that. Thanks. It looks much more comprehensive than this one so I'll close this one. Would be fab if the other one could be merged soon though as it seems like it's a pretty useful driver (given that 3 people have now written it). Also are we no longer giving prs a 'driver' tag? I should have checked more carefully anyway but the reason I didnt see #488 is because I looked for 'driver' prs rather than 'feat's

@nataliejpg nataliejpg closed this Mar 9, 2017
@giulioungaretti
Copy link
Contributor

@nataliejpg yes that's the idea to have drive/foo but being humans we tend to fail sometimes :D
I will just merge it as proposed, and we'll fix the suspected bugs it may have as we go!

@giulioungaretti
Copy link
Contributor

also @nataliejpg it is under driver/foo 🌹

@nataliejpg
Copy link
Contributor Author

@giulioungaretti cool cool, just wanted to check, it wasn't a moan (although I did double check and it's under 'feat: Add basic driver for Keithley 2400' so I wouldn't have called that 'driver/foo'. It did make me realise that the ZNB20 update I did is under feat as well where it shouldn't be so @WilliamHPNielsen is by no means the only fallible one)

@giulioungaretti
Copy link
Contributor

<3 <3

@nataliejpg nataliejpg deleted the driver/Keithley2400 branch July 28, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants