Enable building of docs using 3.13#6585
Merged
jenshnielsen merged 1 commit intomicrosoft:mainfrom Nov 25, 2024
Merged
Conversation
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6585 +/- ##
=======================================
Coverage 69.37% 69.37%
=======================================
Files 340 340
Lines 31322 31322
=======================================
Hits 21729 21729
Misses 9593 9593 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
daaa1f9 to
71110c0
Compare
Collaborator
Author
|
Disabling viewcode confirms that this also fixes the issue. Some debugging specifically adding In sphinx viewcode.py here Reveals that this is a problem with connectionplus probably related to wrapt |
71110c0 to
07ac970
Compare
07ac970 to
9c6e294
Compare
einsmein
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that wrapt 1.17.0 is released we can build docs with 3.13
Lifted from #6494 since this is currently failing.
Issue is resolved in wrapt 1.17.0rc1 just need to wait for release and we can merge this
Disabling parallel build does not seem to make a difference.
Disabling the extensions one by one seems to indicate that the docs build error is related to autodocsumm, other debugging points towards viewsource. It may be a combination of these extensions