Add methods to find instruments from parameter chain#6616
Merged
picarro-yren merged 7 commits intomicrosoft:mainfrom Nov 14, 2024
Merged
Add methods to find instruments from parameter chain#6616picarro-yren merged 7 commits intomicrosoft:mainfrom
picarro-yren merged 7 commits intomicrosoft:mainfrom
Conversation
added 2 commits
November 12, 2024 13:31
Contributor
Author
|
@microsoft-github-policy-service agree |
trevormorgan
approved these changes
Nov 12, 2024
Contributor
trevormorgan
left a comment
trevormorgan
left a comment
There was a problem hiding this comment.
looks like a nice addition to qcodes!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6616 +/- ##
==========================================
+ Coverage 69.35% 69.37% +0.01%
==========================================
Files 340 340
Lines 31279 31293 +14
==========================================
+ Hits 21694 21708 +14
Misses 9585 9585 ☔ View full report in Codecov by Sentry. |
samantha-ho
reviewed
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new methods to find instruments of specific type in a parameter chain.