DelegateParameters inherit their source's settable/gettable/snapshot_value/unit/label#6648
Merged
jenshnielsen merged 8 commits intomicrosoft:mainfrom Nov 22, 2024
Conversation
Contributor
Author
|
@jenshnielsen Not sure if this is a big enough issue to rethink the implementation. What are your thoughts? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
==========================================
+ Coverage 69.35% 69.37% +0.01%
==========================================
Files 340 340
Lines 31303 31322 +19
==========================================
+ Hits 21710 21729 +19
Misses 9593 9593 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
b0a2781 to
a1752ba
Compare
d60d310 to
1c89455
Compare
einsmein
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug observed when chaining multiple DelegateParameters, and changing the source at the bottom of the chain.
In the previous implementation, a DelegateParameter only updated it's internal
_settableand_gettableattributes when thesourcewas changed. But it is possible to set up a chain of DelegateParameters and then change the 'root' source Parameter. This updates the bottom-most DelegateParameter, but all of the other DelegateParameters in the chain will not update.This PR changes the implementation to override the
ParameterBaseimplementation of thegettableandsettableproperties, so that they reflect the underlyingsourceparameter, no matter what it may be.