Fix bug: delegate parameter doesn't call its source to get value#6671
Merged
jenshnielsen merged 3 commits intomicrosoft:mainfrom Nov 28, 2024
Merged
Fix bug: delegate parameter doesn't call its source to get value#6671jenshnielsen merged 3 commits intomicrosoft:mainfrom
jenshnielsen merged 3 commits intomicrosoft:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6671 +/- ##
=======================================
Coverage 69.37% 69.37%
=======================================
Files 340 340
Lines 31322 31328 +6
=======================================
+ Hits 21729 21735 +6
Misses 9593 9593 ☔ View full report in Codecov by Sentry. |
einsmein
approved these changes
Nov 28, 2024
jenshnielsen
added a commit
to jenshnielsen/Qcodes
that referenced
this pull request
Nov 28, 2024
…r_bug Fix bug: delegate parameter doesn't call its source to get value
Merged
jenshnielsen
added a commit
that referenced
this pull request
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
A DelegateParameter should redirect to its source for the value but instead <function Parameter.init.._get_manual_parameter> is called and 0.0 is returned.
Cause
The reason why DelegateParameter doesn't call its source for the value is because of the following lines in Parameter.init:
When external_parameter is created, its source is None so it's not gettable and its get_raw is thus bound to _get_manual_parameter.
Solution
It turns out that even though gettable property of DelegateParameter is False when source is None, _gettable attribute is True because
get_rawis defined in parameterSo the solution we propose is to use _gettable attribute instead of gettable property in Parameter.init.