Oxford Triton driver: only add magnet parameters if one is present#6792
Conversation
|
thanks @thangleiter Looks fine, Note that this driver is not particularly well maintained. There is also a driver in https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/src/qcodes_contrib_drivers/drivers/OxfordInstruments/Triton.py which may be of interest. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6792 +/- ##
==========================================
- Coverage 69.39% 69.37% -0.02%
==========================================
Files 340 340
Lines 31335 31341 +6
==========================================
Hits 21744 21744
- Misses 9591 9597 +6 ☔ View full report in Codecov by Sentry. |
Thanks, unfortunately that driver is basically just an offline log file parser and does not interact with the fridge at all. |
This patch tests if the Triton can communicate with the magnet. If not, parameters pertaining to the magnet are not added to the instrument. This avoids complications when snapshotting the instrument for instance.
Reasons for communication failure are