Oxford ips driver new parameters#6889
Merged
astafan8 merged 10 commits intomicrosoft:mainfrom Feb 21, 2025
Merged
Conversation
…tching the status of magnet heater.
… important temperatures of magnet, PT1 and PT2. Also add a parser to the start for parsing the temperature from response
Contributor
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Thanks @panasee looks good. Left one inline question and a missing type hint. Also please have a look at the precommit job and fix any issue there and then this is ready to merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6889 +/- ##
=======================================
Coverage 69.38% 69.39%
=======================================
Files 341 341
Lines 31386 31399 +13
=======================================
+ Hits 21776 21788 +12
- Misses 9610 9611 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
…/panasee/Qcodes into oxford-ips-driver-new-parameters
Contributor
Author
|
Hello, I've fixed all the issues on my side. Please have a look. |
astafan8
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added several parameters into the oxford MercuryiPS driver, enabling the control of the heaters and the sensing of internal temperatures (magnet, PT1, and PT2 stage of cryogenic system). The new driver has been tested on a real-world iPS device with only a z-axis magnet and all three temperature sensors.
Implementation details
This pull request includes several updates to the
src/qcodes/instrument_drivers/oxford/MercuryiPS_VISA.pyfile, focusing on adding new parameters and a parser function. The most important changes include the addition of a temperature parser function and new parameters for heater switch and temperature readings.New Parser Function:
_temp_parserfunction to parse response strings into SI temperature values.New Parameters:
heater_switchparameter to manage the heater switch status and settings. The heater switch control is bound to each WorkerPS, accepting "ON" and "OFF" as inputs.magnet_temp,pt1_temp, andpt2_tempparameters for reading temperatures from different sensors, utilizing the new_temp_parserfunction. The addresses of sensors are stored statically within the overall iPS classBreaking Changes
No breaking changes. But I am not sure if the heaters and temperature sensors exist for all MercuryiPS instruments.
Currently, the addresses of temperature sensors are written statically in the driver. Not sure if they could change across different systems.