Feature/control parameters plotted in plot dataset #6931
Conversation
…ttps://github.com/harrietoxinst/Qcodes into feature/control-parameters-plotted-in-plot_dataset
…ttps://github.com/harrietoxinst/Qcodes into feature/control-parameters-plotted-in-plot_dataset
|
@microsoft-github-policy-service agree company="Oxford Instruments" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6931 +/- ##
=======================================
Coverage 59.91% 59.92%
=======================================
Files 342 342
Lines 31448 31468 +20
=======================================
+ Hits 18842 18856 +14
- Misses 12606 12612 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
|
Thanks for reviewing. I have committed the suggested change and fixed the errors for pre-commit check. |
|
I have looked at the pytest fail which seems unrelated to the changes I've made, consistent with previous iterations of this PR passing that test. Is this an intermittently failing test perhaps? I have tried to re-run this test locally and it passes. Would someone be able to re-run this test please? |
|
@harrietoxinst The failure is indeed unrelated. Would you have the time to write a few tests for this code. tests would probably go to tests/dataset/test_plotting.py I would expect you to be able to write tests by copying and modifying some of the existing tests |
This PR introduces a
parametersargument to theplot_datasetfunction such that not all dependent parameters have to be plotted if this behaviour is not desired. This closes #6898 . Motivation for this change is further outlined there.Default behaviour of
plot_datasetremains unchanged. I have also added theparametersargument to theplot_by_idfunction preserving the equivalent behaviour shared byplot_by_idandplot_dataset.To provide an example of when/how this might be used I have added the following under 1.2 Two interleaved 1D sweeps in the Offline Plotting Tutorial notebook: