Skip to content

Enable a subset of pyright strict rules#6943

Merged
jenshnielsen merged 7 commits intomicrosoft:mainfrom
jenshnielsen:pyright_strict
Mar 10, 2025
Merged

Enable a subset of pyright strict rules#6943
jenshnielsen merged 7 commits intomicrosoft:mainfrom
jenshnielsen:pyright_strict

Conversation

@jenshnielsen
Copy link
Collaborator

No description provided.

@jenshnielsen jenshnielsen requested a review from a team as a code owner March 6, 2025 15:07
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (c04c4a7) to head (715da7b).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...es/instrument_drivers/american_magnetics/AMI430.py 33.33% 2 Missing ⚠️
...strument_drivers/american_magnetics/AMI430_visa.py 33.33% 2 Missing ⚠️
src/qcodes/instrument/mockers/ami430.py 0.00% 1 Missing ⚠️
...ent_drivers/signal_hound/SignalHound_USB_SA124B.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6943   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files         341      342    +1     
  Lines       31399    31409   +10     
=======================================
+ Hits        21788    21797    +9     
- Misses       9611     9612    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
@jenshnielsen jenshnielsen enabled auto-merge March 10, 2025 12:42
@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 10, 2025
Merged via the queue into microsoft:main with commit e954bd2 Mar 10, 2025
18 checks passed
@jenshnielsen jenshnielsen deleted the pyright_strict branch March 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants