Feat/parameter value change callback#7014
Merged
jenshnielsen merged 20 commits intomicrosoft:mainfrom Apr 3, 2025
Merged
Conversation
… to global class-level with tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7014 +/- ##
==========================================
- Coverage 59.92% 59.91% -0.02%
==========================================
Files 342 342
Lines 31426 31448 +22
==========================================
+ Hits 18832 18842 +10
- Misses 12594 12606 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cetin-oqs
reviewed
Apr 1, 2025
Contributor
|
@jenshnielsen If the naming convention and implementation are good for your side, then these changes will work for us too. |
jenshnielsen
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modify a feature implemented in an existing PR #6934
Specifically, it adds a capability to set an
on_set_callbackon parameter instances, which overwrites theglobal_on_set_callbackset on a class.