Bugfix: dond uses the correct register_name for shapes#7199
Merged
jenshnielsen merged 5 commits intomicrosoft:mainfrom Jun 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7199 +/- ##
=======================================
Coverage 59.94% 59.94%
=======================================
Files 342 342
Lines 31517 31517
=======================================
Hits 18893 18893
Misses 12624 12624 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
detect_shape_of_measurementand_register_parameterutility functions used to infer the correct shape of Parameters, and particularly ParameterWithSetpoints, to useregister_nameinstead offull_name. Since these parameters are registered byregister_name, this mismatch can cause datasets to fail to infer or use the data shape correctly.Closes #7198