Skip to content

Use Mapping rather than dict in DataSetDefinition #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenshnielsen merged 1 commit into from
Nov 3, 2025
Merged

Use Mapping rather than dict in DataSetDefinition #7616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/qcodes/dataset/measurement_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

import time
from collections.abc import Generator, Sequence
from collections.abc import Generator, Mapping, Sequence
from contextlib import ExitStack, contextmanager
from dataclasses import dataclass
from typing import TYPE_CHECKING, Any
Expand Down Expand Up @@ -37,7 +37,7 @@ class DataSetDefinition:
experiment: Experiment | None = None
"""An optional argument specifying which Experiment this dataset should be
written to"""
metadata: dict[str, Any] | None = None
metadata: Mapping[str, Any] | None = None
"""An optional dictionary of metadata that will be added to the dataset
generated by this definition"""

Expand Down
Loading