Restore deprecated parameter setters and getters#790
Merged
WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom Oct 16, 2017
Merged
Restore deprecated parameter setters and getters#790WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom
WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
Contributor
|
I put in on my todo list |
Contributor
|
This does not solve the issue with the The issue is the following: a parameter is added using the |
Collaborator
Author
|
Ok can you merge #788 and I will try to fix that here too |
Contributor
|
Done. |
This is how the official documentation does it and avoids a number of linter warnings
unbreaks some scripts and drivers that may be relying on this
jenshnielsen
force-pushed
the
parameter_restore_deprecated
branch
from
bd07c47 to
101c3bb
Compare
the order is still scrambled but there is not much we can do about that
Collaborator
Author
|
Ok I think that should have been taken care of now too |
Contributor
|
As far as I can see, it solves the issue. 👍 |
WilliamHPNielsen
approved these changes
Oct 16, 2017
Contributor
WilliamHPNielsen
left a comment
WilliamHPNielsen
left a comment
There was a problem hiding this comment.
Let's get this in. More can be added later.
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 16, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Restore deprecated parameter setters and getters (#790)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #788
Basically add set and get back for delay and step as deprecated functions to unbreak anything that depends on it along with allowing step to be zero as documented in the tutorial.
Also updates the tutorial to use non deprecated properties