Don't snapshot array and multiparameters per default#800
Merged
WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom Oct 20, 2017
Merged
Don't snapshot array and multiparameters per default#800WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom
WilliamHPNielsen merged 7 commits intomicrosoft:masterfrom
Conversation
This is an API Change but mostly restores the behaviour \n prior to the merge of the parameter improvements
As we default to skipping array and multiparameters
0ee1d99 to
6510a08
Compare
Contributor
|
Re the two against points:
So... let's just go with this one. |
Contributor
|
[erroneously posted rubbish here] |
WilliamHPNielsen
approved these changes
Oct 20, 2017
Contributor
WilliamHPNielsen
left a comment
There was a problem hiding this comment.
Let's get this in.
giulioungaretti
pushed a commit
that referenced
this pull request
Oct 20, 2017
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Don't snapshot array and multiparameters per default (#800)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #797 works by disabling snapshot storage for Array and Multiparamters by default
Pro this
Against
@WilliamHPNielsen @nulinspiratie