Skip to content

fix: rescale also works for a dataset that is not completed #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nulinspiratie wants to merge 1 commit into from
Closed

fix: rescale also works for a dataset that is not completed #862

nulinspiratie wants to merge 1 commit into from

Conversation

@nulinspiratie
Copy link
Contributor

@nulinspiratie nulinspiratie commented Nov 10, 2017

Currently, MatPlot's rescale_axis does not work if the data array contains nan's. Therefore, it doesn't work if you prematurely stop a loop.

Changes proposed in this pull request:

  • Use np.nanmax instead of np.array.max, which ignores nans

@jenshnielsen @WilliamHPNielsen

@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Nov 30, 2017

I think this is all contained within #875 so closing this

@nulinspiratie nulinspiratie deleted the feature/Matplot_rescale_nans branch March 25, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nulinspiratie @jenshnielsen