Closed
Conversation
2) added pyvisa-sim in the environment.yml
2) Type hints
…_no_arrayed_params
…MI430_no_arrayed_params
Collaborator
jenshnielsen
left a comment
jenshnielsen
left a comment
There was a problem hiding this comment.
Looks good left some inline comments
| """ | ||
| A "meta" instrument which controls three AMI430 instruments for combined X, Y and Z action | ||
|
|
||
| Args |
Collaborator
There was a problem hiding this comment.
This looks like numpy doc style or something in between
| This parameter holds the AMI430_3D 3 dimensional parameters | ||
|
|
||
| Args | ||
| ---- |
| return False | ||
|
|
||
| def set_field(self, value, *, perform_safety_check=True): | ||
| def set_field(self, value: float, perform_safety_check: bool=True) ->None: |
Collaborator
There was a problem hiding this comment.
Did you intentionally remove the * that makes the following parameters keyword only?
Member
Author
There was a problem hiding this comment.
Yeah I did, as I do not get the point of the practice.
Collaborator
There was a problem hiding this comment.
Here it's imho not that important but it makes sense for functions with many arguments and especially more than one non-keyword argument
Collaborator
|
Travis fails due to RST issues in the documentation build |
…/Qcodes into AMI430_no_arrayed_params
…_no_arrayed_params
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 33 33
Lines 4536 4536
=======================================
Hits 3567 3567
Misses 969 969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
I still have some things to do:
But perhaps you guys can already give comments.