This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adjust override sample to account for ongoing refactoring. #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I need to do a little more validation before I'm ready to merge this PR, so I'll leave it in draft until I've confirmed the correct behavior using the e2e build, then publish and ping for review. |
Contributor
Author
|
I am going to find a different way to handle this in the refactor PR that should eliminate the need for consumers to make these changes. I did test that this change behaves as expected, so that will give us a path forward when we are ready to remove the old deprecated classes used in this sample |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/qsharp-runtime#476
This is required to unblock the PR above. The
QSimMclass is gone, so directly overriding the intrinsic method is now correct. That still works with the current simulator design, so this change should be safe to merge even before the above goes into qsharp-runtime main branch.