This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Functions for arithmetic, logical, and bitwise functions. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoeken
suggested changes
Aug 28, 2019
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Looks great to me. Just pointed out a few minor issues.
Contributor
Author
|
Thanks for the feedback and catches, @msoeken! I've addressed your comments, should be good for another round now. |
msoeken
suggested changes
Aug 29, 2019
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
I've missed some few issues in the last round.
Standard/src/Bitwise/Bitwise.qs
Outdated
| /// # Remarks | ||
| /// The following are equivalent: | ||
| /// ```Q# | ||
| /// let c = a <<< b; |
Contributor
Author
There was a problem hiding this comment.
Fixed. Thanks for the catch!
Contributor
Author
|
Thanks for the second look, @msoeken! I think it should be good now. |
msoeken
approved these changes
Sep 3, 2019
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Looks all good to me now! Looking forward to have these helpful functions in the Libraries!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new functions as per discussions at #147 for each built-in logical, arithmetic, or bitwise operator, as well as expanding support for the
ComplexandComplexPolartypes to be more consistent. Unfortunately, this work exposed the need to deprecate a few more functions, so this PR also includes appropriate deprecation stubs.