This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Simplify classification API. #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
requested review from
alexeib2,
bettinaheim,
martinquantum and
msoeken
bettinaheim
approved these changes
Nov 26, 2019
| } | ||
| mutable mBest = Length(probabilities); | ||
| mutable bBest = bias; | ||
| mutable bLeft = 0.5 - max0; |
Contributor
There was a problem hiding this comment.
I don't know where our style guide lands; do we always want to declare only one variable at a time? Because at least bLeft and bRight sound like they belong together, and I would suggest declaring them in one statement.
Contributor
Author
There was a problem hiding this comment.
Agreed, I would like to refactor this function in particular much further.
Contributor
Author
There was a problem hiding this comment.
If it's OK, I'd like to do so in a follow-up PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.