Quantum AND gates (a.k.a. CCNOT with constant target) #186

msoeken · 2019-12-11T08:12:26Z

Implements #154

cgranade

This looks like a really good start, thanks for adding this! I think my main area of suggestions would be around the API exposed by this feature. Perhaps it would be worth discussing the API in a little more detail? Thanks!

Standard/tests/ANDTests.qs

Standard/src/Canon/And.qs

Co-Authored-By: Chris Granade <chgranad@microsoft.com>

…nto msoeken/and

msoeken

Thanks for your comments.

Standard/src/Canon/And.qs

Standard/tests/ANDTests.qs

cgranade

(Sorry, hit the wrong button and didn't mean to submit a review— seems that you can't delete a review, though?)

cgranade · 2019-12-16T22:21:43Z

Thanks for your comments.

Thanks for adding this feature, that will be really good to have in! 💕

cgranade

Looks great, thank you so much for the addition! I just had a couple minor suggestions left, but otherwise I think this is ready. Thanks again!

Standard/src/Canon/And.qs

cgranade · 2019-12-18T17:16:09Z

Standard/src/Canon/And.qs

+        mutable qs = new Qubit[2^numControls];
+        set qs w/= 0 <- target;


Very minor, but these could be collapsed into a single statement:

Suggested change

mutable qs = new Qubit[2^numControls];

set qs w/= 0 <- target;

mutable qs = new Qubit[2^numControls] w/ 0 <- target;

Co-Authored-By: Chris Granade <chgranad@microsoft.com>

msoeken · 2019-12-18T22:31:14Z

Thanks for the comments. I integrated them and made some more simplifications and added some more references. From my side it's done now.

* Clarify the restriction on the number of bits for IntAsBoolArray (#171) * Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that * Package updates (#188) * Quantum AND gates (a.k.a. CCNOT with constant target) (#186) * Two AND gate implementations. * Added test case. * Formatting. * Code formatting. * Update Standard/src/Canon/And.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Assertion for 0-target. * Added DOI to references. * Named application for CCNOTop. * Rename operations. * Add Test attribute. * Add links to arXiv. * Rename operations. * Better assertion for 0-target. * Fix bug in LowDepthAnd. * Docs. * Doc string convention. * Controlled variant for `ApplyAnd`. * Controlled AndLowDepth. * Adjoint Controlled LowDepthAnd. * References. * Simplify code. * Apply suggestions from code review Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Integrate comment. * Removed comment ref to IncrementByIntegerPhaseLE (#189) There appears to be no function IncrementByIntegerPhaseLE, and I guess it is covered by ApplyLEOperationOnPhaseLE. Co-authored-by: Chris Granade <cgranade@gmail.com> * New Hadamard and SWAP test operations. (#196) * First work on Hadamard and SWAP test operations. * (c) header and typo fix. * Fixed typo with placement of phase shift. * Put public operations above private. * Added tests for new operations. * Added API documentation comments. * Newline at end of file. * Refactor AA namespace to use Q# style guide (#197) * Began simplifying AA interface. * Expose traditional AA as new public operation. * Removed rest of "AmpAmp" prefix. * Resolve deprecation warning. * Switching to using the new Sdk (#194) * Minor doc fixes (#190) * Minor doc fixes * Minor doc cleanup There are probably still some unstated assumptions on the algorithms. * Add "# Description" for MultiplyByModularInteger ...because there is inline math. Co-Authored-By: Chris Granade <cgranade@gmail.com> * "unitary operation" instead of "unitary operator" Co-Authored-By: Chris Granade <cgranade@gmail.com> * Add "# Description", remove refs in "# Summary" Co-authored-by: Chris Granade <cgranade@gmail.com> * Fix build by updating QML projects to use SDK. Co-authored-by: Mariia Mykhailova <michaylova@gmail.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com> Co-authored-by: numpde <21158052+numpde@users.noreply.github.com>

* Clarify the restriction on the number of bits for IntAsBoolArray (#171) * Clarify the restriction on the number of bits for IntAsBoolArray This should fix #166 by providing a more specific error message. * Update Standard/src/Convert/Convert.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Allow to have bits = 0 Looks like our tests assume that number = 0 with bits = 0 is a valid scenario; updating the change to account for that * Package updates (#188) * Quantum AND gates (a.k.a. CCNOT with constant target) (#186) * Two AND gate implementations. * Added test case. * Formatting. * Code formatting. * Update Standard/src/Canon/And.qs Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Assertion for 0-target. * Added DOI to references. * Named application for CCNOTop. * Rename operations. * Add Test attribute. * Add links to arXiv. * Rename operations. * Better assertion for 0-target. * Fix bug in LowDepthAnd. * Docs. * Doc string convention. * Controlled variant for `ApplyAnd`. * Controlled AndLowDepth. * Adjoint Controlled LowDepthAnd. * References. * Simplify code. * Apply suggestions from code review Co-Authored-By: Chris Granade <chgranad@microsoft.com> * Integrate comment. * Removed comment ref to IncrementByIntegerPhaseLE (#189) There appears to be no function IncrementByIntegerPhaseLE, and I guess it is covered by ApplyLEOperationOnPhaseLE. Co-authored-by: Chris Granade <cgranade@gmail.com> * New Hadamard and SWAP test operations. (#196) * First work on Hadamard and SWAP test operations. * (c) header and typo fix. * Fixed typo with placement of phase shift. * Put public operations above private. * Added tests for new operations. * Added API documentation comments. * Newline at end of file. * Refactor AA namespace to use Q# style guide (#197) * Began simplifying AA interface. * Expose traditional AA as new public operation. * Removed rest of "AmpAmp" prefix. * Resolve deprecation warning. * Begin moving classifier structure creation to Q#. * Moving example datasets into new namespace. * Fix datasets used in layered structure demo. * Fixed bug with cyclic entangling layer. * Use new Hadamard test operation to simplify grad est. * Simplify input encoder logic. * Removed layer construction methods moved out to Q#. * Revised name of approximate input encoder. * Removed unused interop library. * Update pack script for new layout. * Addressing feedback. Co-authored-by: Mariia Mykhailova <michaylova@gmail.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com> Co-authored-by: numpde <21158052+numpde@users.noreply.github.com>

msoeken added 3 commits December 10, 2019 08:21

Two AND gate implementations.

f15a2df

Added test case.

5778c1d

Formatting.

a59a3da

msoeken added the Kind-Enhancement New feature or request label Dec 11, 2019

msoeken requested review from cgranade and vadym-kl December 11, 2019 08:12

Code formatting.

27c9adb

cgranade reviewed Dec 11, 2019

View reviewed changes

Mathias Soeken and others added 5 commits December 13, 2019 16:11

Update Standard/src/Canon/And.qs

697bda4

Co-Authored-By: Chris Granade <chgranad@microsoft.com>

Assertion for 0-target.

e7f05cd

Merge branch 'msoeken/and' of github.com:microsoft/QuantumLibraries i…

67c7451

…nto msoeken/and

Added DOI to references.

cfb5a85

Named application for CCNOTop.

5380e88

msoeken commented Dec 16, 2019

View reviewed changes

Standard/src/Canon/And.qs Show resolved Hide resolved

Standard/src/Canon/And.qs Show resolved Hide resolved

Standard/tests/ANDTests.qs Outdated Show resolved Hide resolved

msoeken and others added 2 commits December 16, 2019 11:44

Rename operations.

b9d3388

Merge branch 'master' into msoeken/and

301a310

cgranade reviewed Dec 16, 2019

View reviewed changes

msoeken added 10 commits December 17, 2019 11:09

Add Test attribute.

fc85ea2

Add links to arXiv.

78b1900

Rename operations.

b06ddf4

Better assertion for 0-target.

5639cf6

Fix bug in LowDepthAnd.

4af583b

Docs.

fb3d6a6

Doc string convention.

678421c

Controlled variant for ApplyAnd.

0f7f9ee

Controlled AndLowDepth.

8b6198a

Adjoint Controlled LowDepthAnd.

21c95b0

msoeken requested a review from cgranade December 18, 2019 11:04

References.

fecfd55

Simplify code.

dbd958a

cgranade approved these changes Dec 18, 2019

View reviewed changes

Mathias Soeken and others added 2 commits December 18, 2019 23:26

Apply suggestions from code review

9f8bdf3

Co-Authored-By: Chris Granade <chgranad@microsoft.com>

Integrate comment.

c099b7e

cgranade merged commit 6c9561a into master Dec 19, 2019

msoeken mentioned this pull request Dec 19, 2019

Quantum AND gates (a.k.a. CCNOT with constant target) #154

Closed

msoeken deleted the msoeken/and branch December 19, 2019 07:47

		mutable qs = new Qubit[2^numControls];
		set qs w/= 0 <- target;

	mutable qs = new Qubit[2^numControls];
	set qs w/= 0 <- target;
	mutable qs = new Qubit[2^numControls] w/ 0 <- target;

Quantum AND gates (a.k.a. CCNOT with constant target) #186

Quantum AND gates (a.k.a. CCNOT with constant target) #186

Uh oh!

Conversation

msoeken commented Dec 11, 2019

Uh oh!

cgranade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msoeken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgranade left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgranade commented Dec 16, 2019

Uh oh!

cgranade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cgranade Dec 18, 2019

Choose a reason for hiding this comment

Uh oh!

msoeken commented Dec 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cgranade left a comment •

edited

Loading