This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Use new UDTs to consolidate and simplify training / validation API. #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinquantum
suggested changes
Jan 2, 2020
Contributor
martinquantum
left a comment
martinquantum
left a comment
There was a problem hiding this comment.
Looks good to me by and large! There were just a few comments (one cosmetic, one about separation of code and data), otherwise, it looks good to me.
martinquantum
approved these changes
Jan 2, 2020
Contributor
|
merging in this PR. Thanks for refactoring, Chris! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new UDTs to help consolidate and simplify the training and validation API, and makes changes that API to be more internally consistent (e.g.: choosing a uniform ordering for inputs). To enable these changes, this PR also introduces two new array functions into the standard library,
ChunksandWhere.