Code quality improvements #203
Conversation
cgranade
requested review from
ScottCarda-MS,
alan-geller,
anpaz,
bettinaheim,
martinquantum,
msoeken and
thomashaener
| auxiliary: 'T, | ||
| system: 'S) | ||
| : Unit { | ||
| body (...){ |
There was a problem hiding this comment.
Missing a space after the body's argument tuple.
|
Thanks for all the feedback, @ScottCarda-MS and @alan-geller, I really appreciate all your comments — especially on a draft PR! I'll work on continuing to address them and on finishing the PR. |
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
…ibraries into cgranade/code-quality
|
There's always more to be done, but I think this is a pretty good step in the right direction, so I'm marking as ready for review now. |
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
Looks great overall.
There are a couple of breaking changes (mostly on things that should be private). I would recommend running and end-to-end QDK build before merging to master.
|
Good suggestion, @anpaz-msft. It looks like the Quantum-NC repo has an accidental dependence on private APIs, such that the end-to-end build failed. I'll go on and address that in the NC repo before merging this in. |
* Use qualified opens to adapt to new location for MeasureAllZ. * Undo qualified open in reference implementation. * Revert to open/as. * Fix minor mistake w/ prev commit.
This PR uses a new experimental linter to begin identifying and resolving code quality issues throughout the libraries, including:
This PR also includes manual fixes to whitespacing, shorthand use for adjoint and controlled declarations, and other similar code quality issues.
Finally, this PR also includes the suggestions made by @alan-geller in #198, and other miscellaneous improvements made while resolving the issues above.