This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improve QML test coverage. #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-geller
approved these changes
Feb 11, 2020
Contributor
alan-geller
left a comment
alan-geller
left a comment
There was a problem hiding this comment.
I can't vouch for this being a complete set, but the test code looks fine.
Co-Authored-By: Alan Geller <alan.geller@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for the QML library, introducing one additional needed fact as a part of that effort, and fixing one bug exposed in the process. This PR also eliminates some warnings elsewhere in the libraries that were bothering me during builds.