This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add verbose option to TrainingOptions UDT, cache state preparation #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
requested review from
alan-geller and
bettinaheim
and removed request for
bettinaheim
bettinaheim
approved these changes
Feb 22, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Looks good, aside from the package numbers.
MachineLearning/src/Types.qs
Outdated
|
|
||
| // Used only to populate default training options to ignore verbose | ||
| // messages. | ||
| function _Ignored(value : String) : Unit {} |
Contributor
There was a problem hiding this comment.
Don't we have a type parametrized ignore function in the standard libraries?
Contributor
Author
There was a problem hiding this comment.
We do, yes. I was thinking it was an operation for some reason. I guess I did need more caffeine after all. Thanks for catching that!
Contributor
Author
Thanks for the review! The package numbers should work, since that's the beta package built from microsoft/qsharp-runtime#151, and since the end-to-end build will clobber package versions anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses microsoft/qsharp-runtime#151 to add a new verbosity option to the
TrainingOptionsUDT. This option allowed for diagnosing microsoft/Quantum#315 more precisely, during which it was identified that the caching of input encoders could improve performance. This PR also implements that solution.