This repository was archived by the owner on Jan 12, 2024. It is now read-only.
New array functions #320
Merged
New array functions #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoeken
added
the
Status-NeedsApiReview
cgranade
reviewed
Sep 1, 2020
Contributor
|
Added to #313 for review. |
Member
Author
|
Thanks for the feedback @cgranade. I made a revision. |
Contributor
Member
Author
|
Thanks @cgranade. This PR is still marked as draft. I wanted to add some more array functions before merging it into the feature branch. |
cgranade
removed
the
Status-NeedsApiReview
cgranade
reviewed
Sep 17, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Looks good so far, mainly had some comments about API documentation comments.
msoeken
commented
Sep 18, 2020
Co-authored-by: Chris Granade <chgranad@microsoft.com>
cgranade
reviewed
Sep 20, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
I think this is nearly there, thanks for doing so much to implement all this!
Co-authored-by: Chris Granade <chgranad@microsoft.com>
cgranade
approved these changes
Sep 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposed some new functions for the
M.Q.Arraysnamespace (PR into feature branch).