This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improved assertion for PrepareUniformSuperposition #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this makes a lot of sense, though I'd also suggest adding an explicit note to the API documentation comment, since its not obvious a priori that the operation is adjointable only as a partial isometry and not as a unitary. |
cgranade
approved these changes
Sep 8, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Approved, modulo comment about documentation. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #221. It adds an assertion that the input state is in state
|0...0>. The assertion will also get triggered when calling theAdjointvariant on a state that is not in a uniform superposition. Ideally, we would check whether the state is eventually in a uniform superposition, but this may add too much overhead.