This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Combinators for ApplyTo of an operation to Head, Tail, Rest, and Most of an array #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
reviewed
Sep 22, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
I think this looks good so far, but I'd suggest additional unit tests and API documentation examples before merging this in.
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Member
Author
|
Thanks for your comments @cgranade. I have added an example to each of the main operations (the one without |
guenp
approved these changes
Sep 23, 2020
guenp
left a comment
guenp
left a comment
There was a problem hiding this comment.
Looks good to me! Just out of curiosity, not sure how often this use case would come up but would it also be useful to apply an operation to any given element N of an array or all even/odd elements?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
ApplyTo{Head,Rest,Tail,Most}{,C,A,CA}combinators described in #313.