Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@ihristova11
Copy link
Contributor

  • Used the @Test() attribute where applicable.
  • Flipped actual and expected in Standard/tests/Math/OperatorFunctionTests.qs

Resolves #340

@ghost
Copy link

ghost commented Oct 14, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution! It looks like the CLA still needs signed, but other than that, I think this is good to bring in once CI completes. Thank you again!

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Co-authored-by: Chris Granade <cgranade@gmail.com>
@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade
Copy link
Contributor

/azp run

@cgranade cgranade added the automerge Pull request is ready to be automatically merged, pending checks and reviews. label Oct 16, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ihristova11
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 350 in repo microsoft/QuantumLibraries

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cgranade cgranade merged commit 50dd29b into microsoft:main Oct 30, 2020
@ihristova11 ihristova11 deleted the update-unit-tests branch October 30, 2020 07:38
@ihristova11
Copy link
Contributor Author

ihristova11 commented Oct 30, 2020

@cgranade Thank you very much for your assistance with this. :) Is it possible to add the hactoberfest-accepted label as well as I am trying to participate this year?

@cgranade cgranade added the Hacktoberfest-Accepted Contribution accepted for consideration in Hackathon 2020. label Nov 2, 2020
guenp pushed a commit that referenced this pull request Nov 6, 2020
* Update manifest for signed builds (#357)

* Missed dll for signing (#361)

* Update unit tests to use @test attribute (#350)

* Update tests using the @test attribute.

* Update tests using the @test() attribute.

* Flip actual and expected.

* Update Standard/tests/Math/OperatorFunctionTests.qs

Co-authored-by: Chris Granade <cgranade@gmail.com>

Co-authored-by: Chris Granade <cgranade@gmail.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>

* signing for magic (#362)

* Build 0.13.2010.2604. (#364)

Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Co-authored-by: Andres Paz <anpaz@microsoft.com>

* Adapting to API update in qsharp-runtime/#370 (#363)

Co-authored-by: Andres Paz <anpaz@microsoft.com>
Co-authored-by: Irina Hristova <hristova119@gmail.com>
Co-authored-by: Chris Granade <cgranade@gmail.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Co-authored-by: Ryan Shaffer <ryan.shaffer@microsoft.com>
Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Pull request is ready to be automatically merged, pending checks and reviews. Hacktoberfest-Accepted Contribution accepted for consideration in Hackathon 2020.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update unit tests to use @Test attribute, descriptive names

3 participants