Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Add PrivateAssets="All" to IQ# package reference#351

Merged
rmshaffer merged 1 commit intomainfrom
rmshaffer/visualization-references
Oct 15, 2020
Merged

Add PrivateAssets="All" to IQ# package reference#351
rmshaffer merged 1 commit intomainfrom
rmshaffer/visualization-references

Conversation

@rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Oct 15, 2020

This change improves the performance of loading the Microsoft.Quantum.Standard.Visualization package inside IQ# by telling NuGet to skip resolution of the IQ#-specific dependency.

This resolves microsoft/iqsharp#338.

@cgranade
Copy link
Contributor

Approved as I'm OK with this coming in, regardless of whether we also apply a more general change in IQ#.

@rmshaffer
Copy link
Contributor Author

Approved as I'm OK with this coming in, regardless of whether we also apply a more general change in IQ#.

Makes sense to me, too!

@rmshaffer rmshaffer marked this pull request as ready for review October 15, 2020 18:17
@rmshaffer rmshaffer merged commit 9888bbb into main Oct 15, 2020
@rmshaffer rmshaffer deleted the rmshaffer/visualization-references branch October 15, 2020 20:01
@rmshaffer rmshaffer restored the rmshaffer/visualization-references branch October 15, 2020 20:01
@rmshaffer rmshaffer deleted the rmshaffer/visualization-references branch October 15, 2020 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import qsharp takes a very long time

2 participants