This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 180
API review July 2022 #608
Merged
Merged
API review July 2022 #608
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bb53590
API review July 2022
msoeken eb03f69
Apply suggestions from code review
msoeken dad67af
Apply suggestions from code review
msoeken 81e2b24
Apply suggestions from code review
msoeken e3302a9
Update api-design-2022-07.md
msoeken 338646d
Update api-design-2022-07.md
msoeken 50637f0
Merge branch 'main' into msoeken/api-review-2207
msoeken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Q# API Design Discussions / July 2022 | ||
|
|
||
| Reviewers (in order by username): @tcNickolas, @msoeken, @cgranade | ||
|
|
||
| ## Agenda | ||
|
|
||
| - https://github.com/microsoft/QuantumLibraries/issues/598 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/601 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/602 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/607 | ||
|
|
||
| ## Discussion | ||
|
|
||
| ### Fixed point truncation | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/598 | ||
|
|
||
| **Reviews**: | ||
| * @tcNickolas, *approve*, left a comment | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Approved | ||
|
|
||
| --- | ||
|
|
||
| ### Table lookup | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/601 | ||
|
|
||
| **Reviews**: | ||
msoeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @tcNickolas, *approve*, left comments | ||
msoeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @msoeken, *approve*, left comments | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Postponed, requires more discussion | ||
|
|
||
| --- | ||
|
|
||
| ### Windowed unitary application | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/602 | ||
|
|
||
| **Reviews**: | ||
msoeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @tcNickolas, *approve* | ||
msoeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @msoeken, *approve*, left comments | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Approved as `ApplyToEachWindow` without `argumentTransform`, without `target` argument, with type parameter for input array, and with all 4 functor variants. | ||
|
|
||
| --- | ||
|
|
||
| ### New operation: Apply arithmetic function via table lookup | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/607 | ||
|
|
||
| **Reviews**: | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
| * @msoeken, *approve*, left comments | ||
|
|
||
| **Consensus**: Approved after comments | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.