Remove parallelized Rar Extractor #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying dependency's "OpenEntryStream" api is not threadsafe as it implicitly calls the ctor for RarStream which directly maniuplates the shared reference to the overall Stream for the archive file, resulting in corrupted files (albeit of the correct quantity) when using the parallel argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying dependency's "OpenEntryStream" api is not threadsafe as it implicitly calls the ctor for RarStream which directly maniuplates the shared reference to the overall Stream for the archive file, resulting in corrupted files (albeit of the correct quantity) when using the parallel argument.
https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Compressors/Rar/RarStream.cs#L34
Fix #102